Undeprecate :class_name #2697
Merged
Undeprecate :class_name #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried to remove `:class_name` (along with some others), as it didn't seem like they had a legitimate use as of thoughtbot#2384 and thoughtbot#2546. But we've been seeing various cases where it's still helpful to have. Closes thoughtbot#2384.
nickcharlton
force-pushed
the
undeprecate-class-name
branch
from
0b2e519 to
ac89843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are going towards v1.0.0, perhaps we should undeprecate
:class_name😄At #2384 and #2546, we have seen legitimate use cases for this option, so perhaps it should be back on the menu after all.
I'm not clear yet about the other deprecations that came with it though:
:foreign_keyand:primary_key. I think those might be ok? Has anyone come across use cases for them? Perhaps @littleforest?While updating the documentation, I realised there's an example that uses
:class_nameand doesn't need it, so I have addressed it.