Add missing translations #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrluis
force-pushed
the
add-missing-translations
branch
from
c0e0a83 to
87de797
Compare
| @@ -15,13 +15,13 @@ It displays a header, and renders the `_form` partial to do the heavy lifting. | |||
| [1]: http://www.rubydoc.info/gems/administrate/Administrate/Page/Form | |||
| %> | |||
|
|
|||
| <% content_for(:title) { "Edit #{page.page_title}" } %> | |||
| <% content_for(:title) { "#{t("administrate.actions.edit")} #{page.page_title}" } %> | |||
There was a problem hiding this comment.
What about passing the page title as an option to the translation? That would be good for languages where the title makes more sense before the edit word. What do you think?
There was a problem hiding this comment.
Agreed, something like
t("administrate.actions.edit_resource", resource: page.page_title)
would be good.
ndrluis
force-pushed
the
add-missing-translations
branch
from
87de797 to
e1219e2
Compare
|
A big 👍. Thanks! |
|
Can you translate |
|
please @ndrluis just keep the good work here |
Add 'new' and 'back' translation
Add 'new' and 'back' translation
|
@ndrluis I'd love to merge this. Could you rebase on |
|
@nickcharlton I enabled the pushes. |
nickcharlton
force-pushed
the
add-missing-translations
branch
from
e1219e2 to
5f3210b
Compare
nickcharlton
added a commit
that referenced
this pull request
Mar 10, 2017
`with_translations` is used to test that a view does actually implement a given translation. Previously, we were resetting the known translations to only use the one under test. We now have many more translations so this approach will fail when visiting a page because of "missing translations". Example: https://git.io/vywpc This came up when merging #344.
This was referenced Mar 10, 2017
nickcharlton
added a commit
that referenced
this pull request
Mar 17, 2017
`with_translations` is used to test that a view does actually implement a given translation. Previously, we were resetting the known translations to only use the one under test. We now have many more translations so this approach will fail when visiting a page because of "missing translations". Example: https://git.io/vywpc This came up when merging #344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some translations that were missing but now I need some help to fill the others locales.