Use tabular figures in table cells #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| font-feature-settings: "kern", "liga", "clig", "calt", "lnum", "tnum"; | ||
| font-kerning: normal; | ||
| font-variant-ligatures: common-ligatures, contextual; | ||
| font-variant-numeric: lining-nums, tabular-nums; |
There was a problem hiding this comment.
Unknown property font-variant-numeric
There was a problem hiding this comment.
It’s real. I think Firefox uses it: https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant-numeric
I think I might be able to tell SCSS-Lint that this is an acceptable property within it’s config…
There was a problem hiding this comment.
Yep! Added in 23efbd1
tysongach
force-pushed
the
tg-tabular-numbers
branch
from
23efbd1 to
bae779b
Compare
|
Here’s a better representation of non-tabular versus tabular numbers: Non-tabular numbers
Tabular numbers
|
|
Very nice 👍 Just to double check, we want to only use those font settings on table cells? Any benefit/harm to doing them more broadly? |
|
@joshuaogle These specific settings, yes, just on table cells. Tabular numbers, for example, wouldn’t feel right within a paragraph. We can likely improve the type in many other areas, as well, though. I bet some helpful adjustments on form inputs, or other places where there’s some heavy data, could be nice. Let’s focus on those in other PR’s… |
tysongach
force-pushed
the
tg-tabular-numbers
branch
from
bae779b to
79a1080
Compare
|
🎉 |
added 2 commits
January 20, 2016 16:50
Tabular figures are set on a fixed width, so that every figure occupies the same amount of horizontal space. Reference: http://practice.typekit.com/lesson/caring-about-opentype-features/
tysongach
force-pushed
the
tg-tabular-numbers
branch
from
79a1080 to
e99a6ad
Compare
c-lliope
added a commit
that referenced
this pull request
Jan 22, 2016
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
Merged
c-lliope
added a commit
that referenced
this pull request
Jan 22, 2016
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabular figures are set on a fixed width, so that every figure occupies the same
amount of horizontal space.
Reference: http://practice.typekit.com/lesson/caring-about-opentype-features/
Take a look at the “Lifetime Value” column in the GIF below and notice how after enabling this features, all of the numbers align horizontally making for a more readable experience.