Loosen normalize-rails required version #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehlah
force-pushed
the
loosen-normalize-version
branch
3 times, most recently
from
9d1f6e7 to
8626fe0
Compare
|
@mehlah we could do Did you notice any visual regressions on your app when you did the update? |
mehlah
force-pushed
the
loosen-normalize-version
branch
from
8626fe0 to
9611fd2
Compare
|
@BenMorganIO 👍 for going with |
|
@mehlah Could you rebase on |
Normalize 4.x has been released a couple weeks ago. Administrate was locking normalize-rails version to 3.x, that forces any recent Rails app to stick with Normalize 3.x. Instead of locking 4.x, this commit suggests to loosen the required version for Administrate to run as it shouldn't have an impact on it's base styles. Normalize 4.x changelog: https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md
mehlah
force-pushed
the
loosen-normalize-version
branch
from
9611fd2 to
619c647
Compare
|
@nickcharlton done :) |
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize 4.x has been released a couple weeks ago (changelog)
Administrate was locking normalize-rails version to 3.x, that forces any
recent Rails app to stick with Normalize 3.x.
Instead of locking 4.x, this commit suggests to loosen the required
version for Administrate to run as it shouldn't have an impact on it's base styles.
Do you agree, or prefer requiring
~> 4.0which may force existing apps relaying on 3.x to upgrade before upgrading Administrate.