only specify ruby version for ci #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Once the build's passing, merge it on in. |
BenMorganIO
force-pushed
the
remove-ruby-version-dependency
branch
from
63fce8e to
f21b7bc
Compare
This was referenced May 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for the developer to have to specify a specific version of ruby. If we have a hard setting of ruby in development, we could end up causing regressions in Rails projects. (Such as bumping ruby to 2.3 and using
&.syntax, and unknowingly causing regressions for 2.2 and 2.1 users.)Also, this is a first step in making sure that we can improve the ruby version coverage for our CI.