Add autoprefixer-rails #767
Conversation
Gemfile.lock
Outdated
| @@ -319,4 +320,4 @@ DEPENDENCIES | |||
| webmock | |||
|
|
|||
| BUNDLED WITH | |||
| 1.14.4 | |||
| 1.14.6 | |||
There was a problem hiding this comment.
Does adjusting the bundle version have any side-effects with Circle or Appraisal? This is something I've seen before (you might want to look at the run commands).
There was a problem hiding this comment.
As far as I know this line only matters when it comes to diagnosing problems with bundler, but I am only mildly certain of that. I am happy to revert the line, though I think that may cause even more confusion if there were a problem with bundler, since our lock file would be inaccurate. Thoughts?
There was a problem hiding this comment.
Something I've been seeing (with dep versions shifting ahead of us here) are loading issues with the version of bundler. Because of the CI setup, it'll end up loading multiple versions and then fails.
What do you think of reverting this line on the assumption that we'll re-run before the next release?
As mentioned in #766, `autoprefixer` isn't currently running on this project, and since we aren't prefixing things by hand this means that selectors that need prefixing aren't getting it. Changes: - Add the `autoprefixer-rails` gem
jcmorrow
force-pushed
the
jm-autoprefixer
branch
from
42b0c31 to
06e3700
Compare
|
Quick question on this one-- will Autoprefixer automatically be running on the assets coming from the project? Will this exclude assets from the main app or will it force users to auto prefix everything, even their own project's assets? |
|
@carlosramireziii I'm actually not sure. Do you know, @jcmorrow? |
|
@carlosramireziii I also do not know. 🤷♀️ I suppose it could be easy to find out though. |
As mentioned in #766,
autoprefixerisn't currently running on this project, and since we aren't prefixing things by hand this means that selectors that need prefixing aren't getting it.Changes:
autoprefixer-railsgemAlso related: