Remove dependency on remote images in tests #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 5, 2017
spec/rails_helper.rb
Outdated
| @@ -32,3 +32,9 @@ module Features | |||
|
|
|||
| ActiveRecord::Migration.maintain_test_schema! | |||
| Capybara.javascript_driver = :poltergeist | |||
| Capybara.register_driver :poltergeist do |app| | |||
| options = { | |||
| phantomjs_options: ['--load-images=no'] | |||
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Hi @pustomytnyk could you please rebase it? Thanks! |
|
Hi @pustomytnyk! If I could get you to fix the two Hound comments, I'd be happy to merge this. |
BenMorganIO
reviewed
Jun 23, 2017
spec/rails_helper.rb
Outdated
| options = { | ||
| phantomjs_options: ['--load-images=no'] | ||
| } | ||
| Capybara::Poltergeist::Driver.new(app, options) |
There was a problem hiding this comment.
Why not just pass the options directly here?
houndci-bot
reviewed
Jun 24, 2017
spec/rails_helper.rb
Outdated
| @@ -32,3 +32,6 @@ module Features | |||
|
|
|||
| ActiveRecord::Migration.maintain_test_schema! | |||
| Capybara.javascript_driver = :poltergeist | |||
| Capybara.register_driver :poltergeist do |app| | |||
| Capybara::Poltergeist::Driver.new(app, phantomjs_options: ["--load-images=no"]) | |||
|
updated.
Hound complained about line being too long (81/80). |
|
Got it, thanks! Merging. |
nickcharlton
pushed a commit
that referenced
this pull request
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with images accessibility in tests (from #819). Issue can be reproduced with limiting internet bandwidth (test still pass if I've fully disabled internet).