Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for search input #891

Conversation

mariusz-blaszczak
Copy link

Added translations to placeholder and hint.

Changed all locales files, but only english and polish are translated
correctly. Other locale files are translated with Google Translate.

Added translations to placeholder and hint.
Changed all locales files, but only english and polish are translated
correctly. Other files are translated with Google Translate.
@mariusz-blaszczak
Copy link
Author

Can anyone review this?

@nickcharlton
Copy link
Member

Looks good, thanks!

@nickcharlton nickcharlton merged commit e43926f into thoughtbot:master May 19, 2017
@tysongach tysongach mentioned this pull request May 20, 2017
iarie pushed a commit to iarie/administrate that referenced this pull request Jun 17, 2017
Added translations to placeholder and hint.
Changed all locales files, but only english and polish are translated
correctly. Other files are translated with Google Translate.
@mariusz-blaszczak mariusz-blaszczak deleted the feature/translate-search-placeholder branch October 9, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants