Fix hiding of search bar when none of searchable columns are used on index page #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 16, 2017
| @@ -134,7 +134,7 @@ def translate_with_resource(key) | |||
|
|
|||
| def show_search_bar? | |||
| dashboard.attribute_types_for( | |||
| dashboard.collection_attributes | |||
| dashboard.all_attributes | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
|
Would you be able to add some tests to this? |
|
@nickcharlton maybe after #843. It waits 20 days already. |
|
@nickcharlton updated. |
* Also unties search scope from representation of collection
|
It'd been a little while on this, so I took your branch and rebased. I'll merge it in now, thanks! |
c4lliope
added
the
views-and-styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untie search from representation of collection