Refactor: Extract Search::Query object #936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failures like:
$ rspec ./spec/lib/administrate/search_spec.rb
...
Failures:
1) Administrate::Search#run searches using lower() + LIKE for all searchable fields
Failure/Error: class User < ActiveRecord::Base; end
NameError:
uninitialized constant ActiveRecord
# ./spec/lib/administrate/search_spec.rb:50:in `block (3 levels) in <top (required)>'
Adding collection scopes/filters means we need to add more involved search query parsing; this gives us a place for that.
This brings method names closer in line with the terms used in the [ActiveRecord::QueryMethods#where documentation](http://api.rubyonrails.org/classes/ActiveRecord/QueryMethods.html#method-i-where), and it makes room for us to use `search_terms` and `query` for some more Administrate-specific methods.
|
The changes here are included in #947, which is the pull request they were made for. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards making it easier to integrate the solution built by @nando in #276.
Adding collection scopes/filters means we need to add more involved search query parsing; this pull request gives us a place for that, instead of cluttering the
Administrate::Searchclass with string-parsing capabilities.This pull request changes no public behaviours.