This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Remove auto-screenshot behavior #800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't distinguish between ClickFailed errors which will be retried, and those which have actually failed for good. This means we end up writing hundreds of screenshot files during a failure, and we sometimes write several screenshot files even when the click ends up working. This isn't feasible to work around in a driver, so this commit removes the behavior from capybara-webkit. Something like this may make more sense in Capybara proper. Resolves #626.
|
Looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't distinguish between ClickFailed errors which will be retried,
and those which have actually failed for good. This means we end up
writing hundreds of screenshot files during a failure, and we sometimes
write several screenshot files even when the click ends up working.
This isn't feasible to work around in a driver, so this commit removes
the behavior from capybara-webkit. Something like this may make more
sense in Capybara proper.
Resolves #626.