This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Use Thor and add --version command
#329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| desc "install", "Install Neat into your project" | ||
| def install | ||
| if neat_files_already_exist? | ||
| puts "Neat files already installed, doing nothing." |
There was a problem hiding this comment.
Do not write to stdout. Use Rails' logger if you want to log.
|
This looks good to me. |
|
Anything holding back this can I help with? |
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env ruby | |||
|
|
|||
| require "neat" | |||
| require File.dirname(__FILE__) + "/../lib/neat.rb" | |||
There was a problem hiding this comment.
This change is seemingly unrelated. You can avoid this, and it's common to do something along these lines: bundle exec ruby -I lib bin/neat
There was a problem hiding this comment.
@teoljungberg Just built the gem locally and testing all of this with and without the above change, and it breaks without. This also aligns with the executable in Bourbon and Bitters, so I’m going to run with it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to Thor, like Bitters and Bourbon, and add a
--versioncommand (was missing before, as described by #315)Closes #315