This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Fixes cocaine path duplication bug #2169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ | |||
| Paperclip.options[:command_path] = "/opt/my_app/bin" | |||
| Paperclip.run("convert", "stuff") | |||
| Paperclip.run("convert", "more_stuff") | |||
| assert_equal 1, [Cocaine::CommandLine.path].flatten.size | |||
| assert_equal 1, Cocaine::CommandLine.path.scan(Paperclip.options[:command_path]).count | |||
| @@ -24,7 +24,8 @@ def interpolates key, &block | |||
| # | |||
| def run(cmd, arguments = "", interpolation_values = {}, local_options = {}) | |||
| command_path = options[:command_path] | |||
| Cocaine::CommandLine.path = [Cocaine::CommandLine.path, command_path].flatten.compact.uniq | |||
| cocaine_path_array = Cocaine::CommandLine.path.try(:split, Cocaine::OS.path_separator) | |||
| Cocaine::CommandLine.path = [cocaine_path_array, command_path].flatten.compact.uniq | |||
|
Thank you! I squashed and merged into master, keeping your authorship. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your path gets too big (e.g., you start appending your path thousands of times) you're going to have a bad time. On our boxes we noticed that paperclip would keep appending the Cocaine command line path, which crushes the CPU after some threshold.
Modified test to check for this and added a fix.