This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Add support for proc arg for fog_public #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if @options[:fog_public].respond_to?(:has_key?) && @options[:fog_public].has_key?(style) | ||
| @options[:fog_public][style] | ||
| value = @options[:fog_public] | ||
| if value.respond_to?(:has_key?) && value.has_key?(style) |
There was a problem hiding this comment.
Use Hash#key? instead of Hash#has_key?.
johnnyshields
force-pushed
the
fog-public-proc-master
branch
from
9a96e84 to
a7ec473
Compare
| end | ||
|
|
||
| it 'sets the @fog_public instance variable to false' do | ||
| assert_equal proc, @dummy.avatar.instance_variable_get('@options')[:fog_public] |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [89/80]
johnnyshields
force-pushed
the
fog-public-proc-master
branch
from
a7ec473 to
80d66c1
Compare
johnnyshields
force-pushed
the
fog-public-proc-master
branch
from
80d66c1 to
09d557c
Compare
|
This looks good, thank you! Why does it fail on Ruby 2.2.2, though? |
|
No clue, I don't believe the failures are related to this PR. |
Indeed it's not: https://travis-ci.org/thoughtbot/paperclip/jobs/159380084 |
|
Thank you! |
|
Thanks for merging so quickly! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the implementation for many other args including
fog_file