Drop support for deprecated Ruby (2.0 and 2.1) and Rails (4.0 and 4.1) versions #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guialbuk
force-pushed
the
drop-support-for-deprecated-ruby-and-rails-versions
branch
from
7daf8d1 to
f5590df
Compare
|
👏 👏 👏 Great! Keep in mind that this means we'll need to bump to 4.0. I'm perfectly fine with that, but it's something to keep in mind. By the way -- I've been keeping a log of changes in NEWS.md. You may want to add this there (it's easier to do it as you go along rather than before a release). |
guialbuk
force-pushed
the
drop-support-for-deprecated-ruby-and-rails-versions
branch
from
e69449d to
a2a415a
Compare
houndci-bot
reviewed
Jul 12, 2017
| @@ -548,7 +548,7 @@ def value_to_attribute_type(value) | |||
| case value | |||
| when true, false then :boolean | |||
| when BigDecimal then :decimal | |||
| when Fixnum then :fixnum | |||
| when Integer then :fixnum | |||
houndci-bot
reviewed
Jul 12, 2017
| @@ -548,7 +548,7 @@ def value_to_attribute_type(value) | |||
| case value | |||
| when true, false then :boolean | |||
| when BigDecimal then :decimal | |||
| when Fixnum then :fixnum | |||
| when Integer then :fixnum | |||
guialbuk
force-pushed
the
drop-support-for-deprecated-ruby-and-rails-versions
branch
from
a2a415a to
7efb40a
Compare
added 2 commits
July 12, 2017 11:49
Remove TravisCI support for Ruby 2.0 and 2.1 Merge Appraisal Gemfiles for different Ruby versions Remove unused variable in Appraisals file
guialbuk
force-pushed
the
drop-support-for-deprecated-ruby-and-rails-versions
branch
from
7efb40a to
abf4ccd
Compare
|
Thanks, @mcmire . I will keep NEWS.md updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of Ruby 2.1 has ended on April, 1st 2017
https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/
Rails 4.1 has reached end of life in 2016
This is an important step to keep shoulda-matchers up to date with current ruby and rails versions and to keep the codebase clean and easier to contribute.