Add support for Rails 8.0 #1239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noting we might want to make this a feature branch, as I suspect we'll need to create several commits to complete this effort. Similar to how we handled the re-write in #1135 |
|
Noting, we'll also want to update the README. |
nickcharlton
force-pushed
the
nc-support-rails-8
branch
from
d5fb01e to
7dfd9d4
Compare
We were getting an incompatibility with the version otherwise being
fetched. By requiring a more recent version, we avoid a bundling issue.
can't activate sqlite3 (>= 2.1), already activated sqlite3-1.7.3-arm64-darwin
This was the state after running, and accepting most of the new changes:
D test/dummy/app/assets/stylesheets/application.css
M test/dummy/bin/setup
M test/dummy/config/boot.rb
M test/dummy/config/environments/development.rb
M test/dummy/config/environments/production.rb
M test/dummy/config/environments/test.rb
M test/dummy/config/initializers/filter_parameter_logging.rb
M test/dummy/config/puma.rb
M test/dummy/public/404.html
M test/dummy/public/422.html
M test/dummy/public/500.html
?? test/dummy/bin/dev
?? test/dummy/bin/rubocop
?? test/dummy/bin/thrust
?? test/dummy/config/initializers/new_framework_defaults_8_0.rb
?? test/dummy/db/migrate/20241129142620_add_service_name_to_active_storage_blobs.active_storage.rb
?? test/dummy/db/migrate/20241129142621_create_active_storage_variant_records.active_storage.rb
?? test/dummy/db/migrate/20241129142622_remove_not_null_on_active_storage_blobs_checksum.active_storage.rb
?? test/dummy/public/400.html
?? test/dummy/public/406-unsupported-browser.html
?? test/dummy/public/icon.png
?? test/dummy/public/icon.svg
?? test/dummy/public/robots.txt
To be able to run the tests, we need to run migrations. To run migrations, we need to be able to refer to the dummy app's Rake tasks. This adds them into the `Rakefile` to we can do that. https://github.com/thoughtbot/administrate/blob/main/Rakefile
nickcharlton
force-pushed
the
nc-support-rails-8
branch
from
b9b8ee9 to
cf0d5ac
Compare
|
I'd apparently forgotten that this had failing lint and test runs, so I've just fixed those. As this is, it'd be helpful to squash these commits into one, well-written one and then merge it. There are other changes we know we want to make to Suspenders, some of which would be worth doing before cutting a release, but doing it that way will be much more straightforward than doing another approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we loosen the constraints to allow us to use Rails 8.0, and update the
dummyapp so that we're testing against Rails 8.0.Closes #1213.