Fix evaluation bug

thoughtworks · Dec 7, 2017 · 2cd9ff9 · 2cd9ff9
1 parent df5c921
commit 2cd9ff9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/deployment/pipeline-definition.json b/deployment/pipeline-definition.json
@@ -24,7 +24,7 @@
                 "ref": "DefaultSchedule"
             },
             "imageId": "ami-1a962263",
-            "instanceType": "r4.2xlarge",
+            "instanceType": "r4.16xlarge",
             "name": "DefaultResource1",
             "id": "datalab-machine",
             "type": "Ec2Resource",
@@ -45,4 +45,4 @@
         }
     ],
     "parameters": []
-}
+}
diff --git a/deployment/run_pipeline.sh b/deployment/run_pipeline.sh
@@ -12,11 +12,12 @@ sudo yum -y install python36 python36-virtualenv python36-pip
 sudo python36 -m pip install boto3
 sudo python36 -m pip install pandas
 sudo python36 -m pip install s3fs
-sudo python36 -m pip install numpy
+# sudo python36 -m pip install numpy
 sudo python36 -m pip install joblib
 sudo python36 -m pip install sklearn
 sudo python36 -m pip install scipy
 sudo python36 -m pip install tables
+# sudo python36 -m pip install jupyter
 
 mkdir -p src && cd src
 aws s3 cp s3://twde-datalab/src.tar.gz .

diff --git a/src/evaluation.py b/src/evaluation.py
@@ -4,7 +4,7 @@
 
 def nwrmsle(predictions, targets, weights):
     if type(predictions) == list:
-        predictions = [np.nan if x < 0 else x for x in predictions]
+        predictions = np.array([np.nan if x < 0 else x for x in predictions])
     elif type(predictions) == pd.Series:
         predictions[predictions < 0] = np.nan
     targets[targets < 0] = np.nan