okcoin: Remove exchange implementation

README.md

@@ -40,7 +40,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | NA |
 | Lbank | Yes | No | NA |
-| Okcoin | Yes | Yes | No |
 | Okx | Yes | Yes | NA |
 | Poloniex | Yes | Yes | NA |
 | Yobit | Yes | NA | NA |

cmd/apichecker/apicheck.go

@@ -32,7 +32,6 @@ const (
 	github               = "GitHub Sha Check"
 	htmlScrape           = "HTML String Check"
 	pathBinance          = "https://binance-docs.github.io/apidocs/spot/en/#change-log"
-	pathOkCoin           = "https://www.okcoin.com/docs/en/#change-change"
 	pathBTSE             = "https://www.btse.com/apiexplorer/spot/#btse-spot-api"
 	pathBitfinex         = "https://docs.bitfinex.com/docs/changelog"
 	pathBitmex           = "https://www.bitmex.com/static/md/en-US/apiChangelog"
@@ -63,7 +62,6 @@ const (
 	createCard           = "UpdatesCard"
 	createChecklist      = "UpdatesChecklist"
 	btcMarkets           = "BTC Markets"
-	okcoin               = "Okcoin"
 )
 
 var (
@@ -483,8 +481,6 @@ func checkChangeLog(htmlData *HTMLScrapingData) (string, error) {
 		dataStrings, err = htmlScrapeAlphaPoint(htmlData)
 	case pathYobit:
 		dataStrings, err = htmlScrapeYobit(htmlData)
-	case pathOkCoin:
-		dataStrings, err = htmlScrapeOk(htmlData)
 	default:
 		dataStrings, err = htmlScrapeDefault(htmlData)
 	}
@@ -1143,7 +1139,7 @@ func nameStateChanges(currentName, currentState string) (string, error) {
 	var num int64
 	var err error
 	switch currentName {
-	case btcMarkets, okcoin:
+	case btcMarkets:
 		if strings.Count(currentName, " ") == 2 {
 			exists = true
 		}

cmd/apichecker/apicheck_test.go

@@ -246,23 +246,6 @@ func TestHTMLScrapeHitBTC(t *testing.T) {
 	}
 }
 
-func TestHTMLScrapeDefault(t *testing.T) {
-	t.Parallel()
-	data := HTMLScrapingData{TokenData: "h3",
-		Key:           "id",
-		Val:           "change-change",
-		TokenDataEnd:  "section",
-		TextTokenData: "p",
-		DateFormat:    "2006-01-02",
-		RegExp:        "(2\\d{3}-\\d{1,2}-\\d{1,2})",
-		CheckString:   "2019-04-28",
-		Path:          "https://www.okcoin.com/docs/en/#change-change"}
-	_, err := htmlScrapeDefault(&data)
-	if err != nil {
-		t.Error(err)
-	}
-}
-
 func TestHTMLScrapeBTSE(t *testing.T) {
 	t.Parallel()
 	data := HTMLScrapingData{RegExp: `^version: \d{1}.\d{1}.\d{1}`,

cmd/apichecker/testupdates.json

@@ -302,22 +302,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Okcoin",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "Val": "./#change-change",
-     "TokenDataEnd": "./#change-",
-     "RegExp": "./#change-\\d{8}",
-     "CheckString": "20200229",
-     "Path": "https://www.okcoin.com/docs/en/#change-change"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Gemini",
    "CheckType": "HTML String Check",

cmd/apichecker/updates.json

@@ -302,22 +302,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Okcoin",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "Val": "./#change-change",
-     "TokenDataEnd": "./#change-",
-     "RegExp": "./#change-\\d{8}",
-     "CheckString": "20200229",
-     "Path": "https://www.okcoin.com/docs/en/#change-change"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Gemini",
    "CheckType": "HTML String Check",

cmd/documentation/exchanges_templates/exchanges_trade_readme.tmpl

@@ -63,7 +63,6 @@ _b in this context is an `IBotExchange` implemented struct_
 | Kraken | Yes | Yes | No |
 | Kucoin | Yes | No | Yes |
 | Lbank | Yes | No | Yes |
-| Okcoin | Yes | Yes | Yes |
 | Okx | Yes | Yes | Yes |
 | Poloniex | Yes | Yes | Yes |
 | Yobit | Yes | NA | No |

cmd/documentation/root_templates/root_readme.tmpl

@@ -41,7 +41,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | NA |
 | Lbank | Yes | No | NA |
-| Okcoin | Yes | Yes | No |
 | Okx | Yes | Yes | NA |
 | Poloniex | Yes | Yes | NA |
 | Yobit | Yes | NA | NA |

config/config.go

@@ -846,8 +846,6 @@ func (c *Config) CheckExchangeConfigValues() error {
 	for i := range c.Exchanges {
 		if strings.EqualFold(c.Exchanges[i].Name, "GDAX") {
 			c.Exchanges[i].Name = "CoinbasePro"
-		} else if strings.EqualFold(c.Exchanges[i].Name, "OKCOIN International") {
-			c.Exchanges[i].Name = "Okcoin"
 		}
 
 		// Check to see if the old API storage format is used

config/config_test.go

@@ -1317,15 +1317,6 @@ func TestCheckExchangeConfigValues(t *testing.T) {
 		t.Error("exchange name should have been updated from GDAX to CoinbasePRo")
 	}
 
-	cfg.Exchanges[0].Name = "OKCOIN International"
-	err = cfg.CheckExchangeConfigValues()
-	if err != nil {
-		t.Error(err)
-	}
-	if cfg.Exchanges[0].Name != "Okcoin" {
-		t.Error("exchange name should have been updated from 'OKCOIN International' to 'Okcoin'")
-	}
-
 	// Test API settings migration
 	sptr := func(s string) *string { return &s }
 	int64ptr := func(i int64) *int64 { return &i }

config_example.json

@@ -2110,85 +2110,6 @@
     }
    ]
   },
-  {
-   "name": "Okcoin",
-   "enabled": true,
-   "verbose": false,
-   "httpTimeout": 15000000000,
-   "websocketResponseCheckTimeout": 30000000,
-   "websocketResponseMaxLimit": 7000000000,
-   "websocketTrafficTimeout": 30000000000,
-   "websocketOrderbookBufferLimit": 5,
-   "baseCurrencies": "USD",
-   "currencyPairs": {
-    "requestFormat": {
-     "uppercase": true,
-     "delimiter": "-"
-    },
-    "configFormat": {
-     "uppercase": true,
-     "delimiter": "-"
-    },
-    "useGlobalFormat": true,
-    "assetTypes": [
-     "spot"
-    ],
-    "pairs": {
-     "spot": {
-      "enabled": "BTC-USD",
-      "available": "BTC-USD,LTC-USD,ETH-USD,ETC-USD,TUSD-USD,CELO-USD,BCH-USD,EOS-USD,XRP-USD,TRX-USD,BSV-USD,USDT-USD,USDK-USD,USDC-USD,DAI-USD,EURS-USD,HBAR-USD,PAX-USD,BTC-USDT,BTC-SGD,ETH-SGD,BTC-EUR,BTC-EURS,ETH-EUR,BCH-EUR,EURS-EUR"
-     }
-    }
-   },
-   "api": {
-    "authenticatedSupport": false,
-    "authenticatedWebsocketApiSupport": false,
-    "endpoints": {
-     "url": "NON_DEFAULT_HTTP_LINK_TO_EXCHANGE_API",
-     "urlSecondary": "NON_DEFAULT_HTTP_LINK_TO_EXCHANGE_API",
-     "websocketURL": "NON_DEFAULT_HTTP_LINK_TO_WEBSOCKET_EXCHANGE_API"
-    },
-    "credentials": {
-     "key": "Key",
-     "secret": "Secret"
-    },
-    "credentialsValidator": {
-     "requiresKey": true,
-     "requiresSecret": true,
-     "requiresClientID": true
-    }
-   },
-   "features": {
-    "supports": {
-     "restAPI": true,
-     "restCapabilities": {
-      "tickerBatching": true,
-      "autoPairUpdates": true
-     },
-     "websocketAPI": true,
-     "websocketCapabilities": {}
-    },
-    "enabled": {
-     "autoPairUpdates": true,
-     "websocketAPI": false
-    }
-   },
-   "bankAccounts": [
-    {
-     "enabled": false,
-     "bankName": "",
-     "bankAddress": "",
-     "bankPostalCode": "",
-     "bankPostalCity": "",
-     "bankCountry": "",
-     "accountName": "",
-     "accountNumber": "",
-     "swiftCode": "",
-     "iban": "",
-     "supportedCurrencies": ""
-    }
-   ]
-  },
   {
    "name": "Okx",
    "enabled": true,

docs/ADD_NEW_EXCHANGE.md

@@ -217,7 +217,6 @@ Yes means supported, No means not yet implemented and NA means protocol unsuppor
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | No |
 | Lbank | Yes | No | NA |
-| Okcoin | Yes | Yes | No |
 | Okx | Yes | Yes | NA |
 | Poloniex | Yes | Yes | NA |
 | Yobit | Yes | NA | NA |
@@ -247,7 +246,6 @@ var Exchanges = []string{
 	"kraken",
 	"kucoin",
 	"lbank",
-	"okcoin",
 	"okx",
 	"poloniex",
 	"yobit",

docs/MULTICHAIN_TRANSFER_SUPPORT.md

@@ -64,7 +64,6 @@ $ ./gctcli withdrawcryptofunds --exchange=binance --currency=USDT --address=TJU9
 | Kraken | Yes | Yes | Front-end and API don't match total available transfer chains |
 | Kucoin |  Yes | Yes | |
 | Lbank | No | No | |
-| Okcoin | Yes | Yes | |
 | Okx | Yes | Yes | |
 | Poloniex | Yes | Yes | |
 | Yobit | No | No | |

docs/OHLCV.md

@@ -86,7 +86,6 @@ A helper tool [cmd/dbseed](../cmd/dbseed/README.md) has been created for assisti
 | Kraken         | Y           |
 | Kucoin         | Y           |                 
 | lBank          | Y           |                
-| Okcoin         | Y           |  
 | Okx            | Y           |         
 | Poloniex       | Y           |          
 | Yobit          |             |           

engine/helpers.go

@@ -49,7 +49,6 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/exchanges/kraken"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/kucoin"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/lbank"
-	"github.com/thrasher-corp/gocryptotrader/exchanges/okcoin"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/okx"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/poloniex"
@@ -1036,8 +1035,6 @@ func NewSupportedExchangeByName(name string) (exchange.IBotExchange, error) {
 		return new(kucoin.Kucoin), nil
 	case "lbank":
 		return new(lbank.Lbank), nil
-	case "okcoin":
-		return new(okcoin.Okcoin), nil
 	case "okx":
 		return new(okx.Okx), nil
 	case "poloniex":