GateIO: Split Futures into USDT and CoinM #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easier development of non-stacked version upgrades. Though the PRs still need to be merged sequentially, or renumbered right before merging
gbjk
requested review from
shazbert,
gloriousCode and
thrasher-
and removed request for
shazbert and
gloriousCode
* Fix CancelBatchOrders using wrong endpoint for CoinMarginedFutures * Fix TestGetActiveOrders expecting currency.ErrCurrencyPairsEmpty
gbjk
force-pushed
the
feature/gateio_split_futures
branch
from
002f3c5 to
b45be62
Compare
shazbert
requested changes
Feb 10, 2025
Comment on lines
+2253
to
+2255
| func (c *FuturesContract) openInterest() float64 { | ||
| return c.QuantoMultiplier.Float64() * float64(c.PositionSize) * c.IndexPrice.Float64() | ||
| } |
There was a problem hiding this comment.
Not you but this looks like notional value not open interest. Open interest can be derived from GetFutureStats this call
There was a problem hiding this comment.
Okay. I think that's outside the scope of this PR, in that it's an existing bug from #1417 which isn't made worse by this change.
It does throw shade on the abstraction work done to support this bug though 😂
@gloriousCode Could you glance and confirm that you agree this is incorrect?
I'll open the issue and address it in a separate PR, if so.
There was a problem hiding this comment.
I ran the tests, looked at the numbers, carried the one, compared with the website and confirmed it is wrong
shazbert
requested changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
GateIO has divergent URLs for handling CoinM and USDT futures, and Delivery Futures.
The changes originally in GateIO made sense prior to shazbert's asset based routing system, but it's clear now that in contexts where it's possible, we want to ensure asset splits that allow request/response routing.
Delivery Futures are actually USDT Delivery futures, and if GateIO get around to introducing CoinM Delivery Futures we'll have to split that too.
This is a pre-cursor to better websocket connection/subscription routing for this exchange (and others)
Progresses #1764
Changes
Type of change
How has this been tested