-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry if fail to upload #45
Comments
Sporadically ? My deployments systematically fail 3 times out of 4 because of Rollbar source maps uploads with the following error: |
I am also getting sporadically failed builds that will succeed after a rebuild. It's a shame that I have to re-run my entire build process just to kick off the rollbar upload step. A retry option would be superb! |
This is also a huge issue for my team. One failed upload causes our entire build to fail. This morning, every single Dependabot update branch build has failed twice so far. That's 20 builds I've had to restart already. I honestly don't even care about a retry. I'd be more interested in setting an "acceptable failure threshold" - maybe 5 files by default. 1 failed upload is a much smaller deal than tons of failed builds. I would definitely help out if we could come to a consensus on the behavior. |
@pjaws thanks for the input. As short term workaround, you might want to use |
that short term workaround is permanent solution it seem :) |
I've created a PR for adding a The best scenario would be that rollbar wouldn't fail sporadically, but until then, this might help you out |
Is it possible to add a retry up to say 3-4 times to upload the source maps to rollbar. I've noticed that my build will sporadically fail due to an upload failing.
The text was updated successfully, but these errors were encountered: