Drop support for Webpack v3 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes backward compatibility with deprecated Tapable.plugin interface. Now requires Tabable.hooks interface and thus you will need to be running Webpack 4. BREAKING CHANGE
brandondoran
force-pushed
the
drop-webpack-v3
branch
from
38bcdda to
3e396dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 97 95 -2
Branches 31 30 -1
=========================================
- Hits 97 95 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes backward compatibility with deprecated
Tapable.plugininterface. Now requiresTabable.hooksinterface and thus in order to use the plugin you will need to be running Webpack 4.Dropping
Tapable.pluginsupport will allow for some code cleanup and pave the way for more easily resolving issues such as #45, #68, #183This is a breaking change.