Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This upgrades the http client and related code for handling the file uploads. To the end users there should be no noticeable change in functionality.
tapPromise
hook instead oftapAsync
. This will allow using async/await or promises instead of callbacksasync
dependency and convert methods to async/await instead of callbacks.lodash.reduce
,lodash.find
and use native array methods instead.🛠️ Testing
Setup
Use react example to serve as an integration test of sorts. The example uses .env to set env vars needed for S3 and Rollbar. Create .env from example and fill it with your own settings:
To simplify setup, comment out
S3Plugin
instances inexamples/react/webpack.config.js
so you don't need AWS creds.Test steps
rm -rf node_modules && npm i
npm run build