Feature/public path as function #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 81 89 +8
=====================================
+ Hits 81 89 +8
Continue to review full report at Codecov.
|
Closed
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
# [1.1.0-beta.1](v1.0.2...v1.1.0-beta.1) (2020-10-16) ### Bug Fixes * **ci:** migrate to semantic-release ([d8ae222](d8ae222)) * **docs:** add devtool to usage example and document ([#78](#78)) ([1705a9b](1705a9b)) ### Features * **examples:** added Next.js example ([#83](#83)) ([5a6edd5](5a6edd5)) * **options:** add encodeFilename flag ([#163](#163)) ([4829ebe](4829ebe)), closes [#162](#162) * **publicPath:** public path as function ([#58](#58)) ([041d205](041d205)) * **webpack-api:** support webpack 4 hooks API ([#53](#53)) ([cc3b747](cc3b747))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Thank you for the work you guys have put into this. This package is saving us lots of time.
This PR intends to make a backward compatible API change on the publicPath argument. It would now accept publicPath to be
stringor afunction(string): string.This change would enable users with specific routing needs, as for example NextJs users, to apply whatever routing logic they need to the publicPath of each file. It works by using the function return as the public path for that source file.
I have seen some forks trying to achieve a similar feature with approaches that might be too centered in their own edge cases. I think this approach is more flexible and can attend more user without adding breaking changes.