Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expect dependency and use jest expect #77

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Conversation

brandondoran
Copy link
Collaborator

When migrating to Jest in #62, usage of https://github.com/mjackson/expect was left in order to keep the PR small. In this PR we remove expect dependency and use Jest's expect. Also some minor style cleanup.

@brandondoran
Copy link
Collaborator Author

Codecov Report

Merging #77 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           73        74    +1     
  Branches        18        19    +1     
=========================================
+ Hits            73        74    +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159ea63...3e8b49f. Read the comment docs.

@brandondoran brandondoran merged commit 7b34d32 into master Feb 8, 2020
@brandondoran brandondoran deleted the expect branch March 20, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant