Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multisampling support for Rasterizer #157

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

vitvakatu
Copy link
Member

It's not trivial to make it adjustable by window builder settings, so is it okay to enable it by default?

@vitvakatu vitvakatu requested a review from kvark January 3, 2018 21:58
Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to request MSAA from glutin though

@vitvakatu
Copy link
Member Author

MSAA can be requested from glutin via window builder. It works, I've checked.

bors r=kvark

bors bot added a commit that referenced this pull request Jan 4, 2018
157: Enable multisampling support for Rasterizer r=kvark a=vitvakatu

It's not trivial to make it adjustable by window builder settings, so is it okay to enable it by default?
@bors
Copy link
Contributor

bors bot commented Jan 4, 2018

Build succeeded

@bors bors bot merged commit e037fce into three-rs:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants