Add the ability to change light settings.

[alexander-irbis]

No description provided.

[kvark]

sounds like we could have a Light trait with those methods? Maybe even have the implementation shared somehow

[alexander-irbis]

I have some concerns.
We can use the trait and implement methods in it, then every time we want to use these methods, we should import the trait, it's annoying.
On the other hand, the implemntation with a macro is unfriendly for IDEs.
Do you prefer the case with a trait?

[kvark]

Agreed, there is a bit of an annoyance with a trait. Let's proceed. Bors r+

…

On Jan 1, 2019, at 20:49, Alexander Irbis ***@***.***> wrote: @alexander-irbis commented on this pull request. In src/light.rs: > @@ -44,6 +50,24 @@ impl Ambient { pub(crate) fn new(object: Base) -> Self { Ambient { object } } + + /// Change light color. + pub fn set_color( I have some concerns. We can use the trait and implement methods in it, then every time we want to use these methods, we should import the trait, it's annoying. On the other hand, the implemntation with a macro is unfriendly for IDEs. Do you prefer the case with a trait? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[kvark]

bors r+

[bors]

Build succeeded

• continuous-integration/travis-ci/push