Make audio support optional #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Apr 23, 2019
| opengl = ["gfx_device_gl", "gfx_window_glutin", "glutin"] | ||
| audio = ["rodio"] |
There was a problem hiding this comment.
would you consider changing the feature name to simply "rodio"?
There was a problem hiding this comment.
Sure, but that sounds less like something the user may understand, at first sight.
There was a problem hiding this comment.
yeah, I take the point. Let's proceed then
|
bors r+ |
|
bors r- |
Canceled |
|
It just occurred to me that we are missing CI checks for builds without "audio" feature |
|
This might work, let’s wait for CI to run. |
linkmauve
force-pushed
the
optional-audio
branch
from
3580cb3 to
0400522
Compare
|
Turns out three doesn’t currently build when the opengl feature is absent, I force-enabled it in this commit. It would be useful to fix that eventually. |
|
Seems to test just fine, thanks for the comment! |
|
Amazing work, thank you! |
bors bot
added a commit
that referenced
this pull request
Apr 23, 2019
225: Make audio support optional r=kvark a=linkmauve This reduces the amount of dependencies of 16 if audio support isn’t required by the game. Co-authored-by: Emmanuel Gil Peyrot <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of dependencies of 16 if audio support isn’t required by the game.