support loading stable zero123 in diffuser (fp16 support) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSaurus
approved these changes
Jan 3, 2024
| @@ -638,6 +666,7 @@ def forward( | |||
| loss_sd = 0.5 * F.mse_loss(latents, target, reduction="sum") / batch_size | |||
|
|
|||
| guidance_out = { | |||
| "loss_sds": loss_sd, | |||
There was a problem hiding this comment.
Magic123 uses loss_sd so it will raise an error. How about changing the config file from loss_sds to loss_sd?
There was a problem hiding this comment.
I originally keep/duplicate both the key of both loss_sd and loss_sds, To make it compatible with different models. Yes, i will consider change the cfg. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to support loading the stable-Zero123 into the diffuser with FP16 (half-precision floating-point) compatibility.
Key Features:
The integration has been thoroughly tested for stability and performance improvements.