Manual approval of deployment to dashboard.test.threshold.network #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalinacienciala
force-pushed
the
ci-integration
branch
12 times, most recently
from
3175756 to
3c4f68b
Compare
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-integration/index.html. |
We've integrated deployment of the testnet Token Dashboard into our CI flow (deployment of new goerli packages with contracts triggers start of the `Dashboard / CI` workflow). But we don't want to start the dashboard deploy right away, because first the manual restart of the client nodes is needed. Due to that we're introducing protection of the `testnet` environment. Jobs which will use this environment will need to be manually approved in GH Actions run's details. We don't need to halt the deployment when workflow gets triggered by the merge to `main`, because this trigger is not related to changes to contracts / client and there is no need for the rotation of the client pods. This difference in the need for use of environment protection meant that we needed to split the `build-and-deploy-testnet` job to two separate jobs (another reason for that was that we wanted to use `upstream builds` in case of `workflow_dispatch` trigger). As after the split we would have three jobs that had quite similar steps, we decided to extract the steps to a separate action.
michalinacienciala
force-pushed
the
ci-integration
branch
from
3c4f68b to
7e72cc3
Compare
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-integration/index.html. |
Done |
nkuba
requested changes
Aug 17, 2022
Instad of having the `gcpProject` input, we'll read the project name from the `ci/config/env/goerli.env` config file. We'll aso read the CHAIN_ID from there.
Input will be used to determine the versions of the legacy contracts which will be used to build the dashboard. It will also be used to read environment variables.
Bucket name parametrized. Thanks to this we could merge the deploy steps for preview bucket and for main bucket to one step (now in both cases we'll use `set-website: true`). If in the future the need for different configuration of `set-website` arises, we could parametrize the action further.
Also order of the inputs got changed. First we have parameters relating to building of the code, then inputs related to deployment to GCP bucket.
|
Preview uploaded to preview.dashboard.test.threshold.network/ci-integration/index.html. |
michalinacienciala
force-pushed
the
ci-integration
branch
from
ab9b71c to
ed99c3a
Compare
|
Preview uploaded to preview.dashboard.test.threshold.network/ci-integration/index.html. |
1 similar comment
|
Preview uploaded to preview.dashboard.test.threshold.network/ci-integration/index.html. |
We don't want to fill the default value with value that is supported, to prevent from accidental dispatches of the workflow by people who don't fully understand how the inputs should be configured. Previously we used explicitely incorrect default value, but that may be too much and may be a bit confusing. Let's leave the input without default.
nkuba
requested changes
Aug 17, 2022
The adress was missing `https://`.
|
Preview uploaded to preview.dashboard.test.threshold.network/ci-integration/index.html. |
We want to run `yarn build` for all events starting the workflow.
Merged
3 tasks
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-integration/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-integration/index.html. |
2 tasks
nkuba
requested changes
Aug 17, 2022
.github/workflows/dashboard-ci.yml
Outdated
| environment: goerli | ||
| ethUrlHttp: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }} | ||
| ethUrlWS: ${{ secrets.GOERLI_ETH_HOSTNAME_WS }} | ||
| useUpstreamBuilds: true |
There was a problem hiding this comment.
Shouldn't it be false?
Suggested change
| useUpstreamBuilds: true | |
| useUpstreamBuilds: false |
We shouldn't use `upstreamBuilds` as `upstream_builds` are not available for workflows triggered by ``pull_request` event.
nkuba
approved these changes
Aug 17, 2022
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-integration/index.html. |
georgeweiler
pushed a commit
that referenced
this pull request
Sep 8, 2022
Manual approval of deployment to dashboard.test.threshold.network We've integrated deployment of the testnet Token Dashboard into our CI flow (deployment of new goerli packages with contracts triggers start of the `Dashboard / CI` workflow). But we don't want to start the dashboard deploy right away, because first the manual restart of the client nodes is needed. Due to that we're introducing protection of the `testnet` environment. Jobs which will use this environment will need to be manually approved in GH Actions run's details. We don't need to halt the deployment when workflow gets triggered by the merge to `main`, because this trigger is not related to changes to contracts / client and there is no need for the rotation of the client pods. This difference in the need for use of environment protection meant that we needed to split the `build-and-deploy-testnet` job to two separate jobs (another reason for that was that we wanted to use `upstream builds` in case of `workflow_dispatch` trigger). As after the split we would have three jobs that had quite similar steps, we decided to extract the steps to a separate action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've integrated deployment of the testnet Token Dashboard into our
CI flow (deployment of new goerli packages with contracts triggers
start of the
Dashboard / CIworkflow). But we don't want to start thedashboard deploy right away, because first the manual restart of the
client nodes is needed. Due to that we're introducing protection of the
testnetenvironment. Jobs which will use this environment will need tobe manually approved in GH Actions run's details. We don't need to halt
the deployment when workflow gets triggered by the merge to
main,because this trigger is not related to changes to contracts / client and
there is no need for the rotation of the client pods. This difference in
the need for use of environment protection meant that we needed to split
the
build-and-deploy-testnetjob to two separate jobs (another reasonfor that was that we wanted to use
upstream buildsin case ofworkflow_dispatchtrigger). As after the split we would have threejobs that had quite similar steps, we decided to extract the steps to
a separate action.
Some further optimization of the new action is possible (like adjusting it for the use in the workflow publishing storybook for
componentsrepo, or in a workflow publishing to mainnet bucket), but I think it can be done in separate PRs.TODO:
NETWORK_IDtogoerli.envkeep-network/ci#32 is merged tomaintestnetenvironment (@nkuba)@keep-network/random-beacon,@keep-network/ecdsaand@keep-network/tbtc-v2contracts if they'll be added as dashboard's dependencies before merge of this PR (see https://github.com/threshold-network/token-dashboard/pull/120/files)TODO after the merge:
build-and-deploy-testnet-on-pushgot executed correctly