Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds chakra theme to storybook with Button component as an example #3

Merged
merged 16 commits into from
Sep 22, 2021

Conversation

georgeweiler
Copy link
Contributor

No description provided.

@georgeweiler
Copy link
Contributor Author

I'm open to discussion about how to better manage our storybook. This PR is mostly for the config and to get us chatting. There may be other examples of how we've used storybook in past projects that we should adopt.

Copy link
Member

@nkuba nkuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the workflow only and left some minor comments.

.github/workflows/chromatic.yml Outdated Show resolved Hide resolved
.github/workflows/chromatic.yml Outdated Show resolved Hide resolved
.github/workflows/chromatic.yml Outdated Show resolved Hide resolved
.github/workflows/chromatic.yml Outdated Show resolved Hide resolved
@georgeweiler
Copy link
Contributor Author

Great suggestions @nkuba! I've pushed some updates. I had to make some additional changes to support v2: https://www.chromatic.com/docs/github-actions#support-for-codeactionscheckoutv2code

georgeweiler and others added 3 commits September 22, 2021 08:38
Initial CRA setup

major libraries installed:
    create-react-app
    eslint / prettier
    husky / lint-staged
    storybook
    chakra-ui
pdyraga pushed a commit that referenced this pull request Sep 22, 2021
@georgeweiler
Copy link
Contributor Author

I'm going to merge this into the chakra-theming branch so we are only working with 1 pull request for our theme & storybook

@georgeweiler georgeweiler merged commit a409f16 into chakra-theming Sep 22, 2021
@georgeweiler georgeweiler deleted the storybook-config branch September 22, 2021 23:42
@georgeweiler georgeweiler restored the storybook-config branch September 24, 2021 00:37
@georgeweiler georgeweiler deleted the storybook-config branch October 11, 2021 17:25
georgeweiler added a commit that referenced this pull request Sep 8, 2022
georgeweiler added a commit that referenced this pull request Sep 8, 2022
Adds chakra theme to storybook with Button component as an example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants