Route to upgrade sub page based on token balance #66
Conversation
|
Preview uploaded to https://preview.dashboard.test.threshold.network/route-by-account-balance/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/route-by-account-balance/index.html. |
…nto route-by-account-balance
…nto route-by-account-balance
|
Preview uploaded to https://preview.dashboard.test.threshold.network/route-by-account-balance/index.html. |
There was a problem hiding this comment.
Hook redirects after successful upgrading KEEP/NU to T because the balances changes.
Scenario 1
- I have
KEEPandNUtokensKEEP balance > NU balance - I upgraded
NUtoT - dapp redirected me to the
upgrade/keep
^ There is the same issue when I have KEEP balance < NU balance and want to upgrade from KEEP to T
Scenario 2
- I have only
KEEP.NU balance = 0 - I upgraded all my
KEEPtokens toT - dapp redirected me to the
upgrade/nu
I leave final approval to @Battenfield.
| const isFirstRender = useRef(true) | ||
|
|
||
| useEffect(() => { | ||
| if (isFirstRender.current) { | ||
| isFirstRender.current = false | ||
| } |
There was a problem hiding this comment.
Looks like this flag is unnecessary because:
useEffectwill be triggered on first render,- a condition in the first
ifstatement is met- we set theisFirstRendertofalse, - so in a second
ifstatement the!isFirstRender.currentcondition always betrue
Maybe I missed something but I tested locally and it looks like if(active) is enough.
|
closing, as Chris asked for #77 instead |
No description provided.