chore: rid of fs2 #551
Merged
chore: rid of fs2 #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
graphite-base/551
branch
from
f0ffcfd to
5fabe7b
Compare
pepyakin
force-pushed
the
pep-chore-rid-of-fs2
branch
from
37a9470 to
0321b3c
Compare
pepyakin
force-pushed
the
pep-chore-rid-of-fs2
branch
from
0321b3c to
195f95b
Compare
fs2 was introduced in PR #500, but we actually don't really need that much from it. This commit removes the extra dependency in favor of doing the same directly. I think this is pretty-much equivalent to inlining the code.
pepyakin
force-pushed
the
pep-chore-rid-of-fs2
branch
from
195f95b to
985ad1d
Compare
rphmeier
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs2 was introduced in PR #500, but we actually don't really need that
much from it. This commit removes the extra dependency in favor of doing
the same directly. I think this is pretty-much equivalent to inlining
the code.