fix: first leaf mut have a separator of all 0 #682
+97
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr implements is a function to enforce that the separator of the first leaf in the beatree is all 0.
The reason for opting for a new function is to avoid adding complexity to the leaf_stage logic. Carrying around information about the first leaf would have required a lot of modifications here and there. Now, instead, that rule is enforced by only the new function and the
unwrap_or
within theLeafUpdater::separate
function. Additionally, this edge case is very unlikely, and the function will, for the most part, return after the first check. The goal was to minimize the impact on the critical path and reduce code complexity while maintaining the rule's validity.Closes THR-91