Improve parsing of video speed setting (#1406)

thunder-app · Jun 1, 2024 · fe5f4f7 · fe5f4f7
1 parent 22a9bfd
commit fe5f4f7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/lib/core/enums/video_playback_speed.dart b/lib/core/enums/video_playback_speed.dart
@@ -1,16 +1,18 @@
 enum VideoPlayBackSpeed {
-  pointTow5x(label: '0.25x'),
-  point5x(label: '0.5x'),
-  pointSeven5x(label: '0.75x'),
-  normal(label: '1'),
-  onePointTwo5x(label: '1.25x'),
-  onePoint5x(label: '1.5x'),
-  onePointSeven5x(label: '1.75x'),
-  twoX(label: '2x');
+  pointTow5x(label: '0.25x', value: 0.25),
+  point5x(label: '0.5x', value: 0.5),
+  pointSeven5x(label: '0.75x', value: 0.75),
+  normal(label: '1x', value: 1),
+  onePointTwo5x(label: '1.25x', value: 1.25),
+  onePoint5x(label: '1.5x', value: 1.5),
+  onePointSeven5x(label: '1.75x', value: 1.75),
+  twoX(label: '2x', value: 2);
 
   const VideoPlayBackSpeed({
     required this.label,
+    required this.value,
   });
 
   final String label;
+  final double value;
 }
diff --git a/lib/utils/video_player/src/thunder_video_player.dart b/lib/utils/video_player/src/thunder_video_player.dart
@@ -75,8 +75,8 @@ class _ThunderVideoPlayerState extends State<ThunderVideoPlayer> {
     _betterPlayerController = BetterPlayerController(betterPlayerConfiguration);
     _betterPlayerController
       ..setupDataSource(_betterPlayerDataSource)
-      ..setVolume(thunderBloc.videoAutoMute ? 0 : 4)
-      ..setSpeed(double.parse(thunderBloc.videoDefaultPlaybackSpeed.label.replaceAll('x', '')));
+      ..setVolume(thunderBloc.videoAutoMute ? 0 : 1)
+      ..setSpeed(thunderBloc.videoDefaultPlaybackSpeed.value);
 
     _betterPlayerController.addEventsListener((event) {
       if (event.betterPlayerEventType == BetterPlayerEventType.exception) {

diff --git a/lib/utils/video_player/src/thunder_youtube_player.dart b/lib/utils/video_player/src/thunder_youtube_player.dart
@@ -47,7 +47,7 @@ class _ThunderYoutubePlayerState extends State<ThunderYoutubePlayer> with Single
           loop: state.videoAutoLoop,
           mute: state.videoAutoMute,
         ),
-      )..setPlaybackRate(double.parse(state.videoDefaultPlaybackSpeed.label.replaceAll('x', '')));
+      )..setPlaybackRate(state.videoDefaultPlaybackSpeed.value);
       if (state.videoAutoFullscreen) _ypfController.toggleFullScreenMode();
     } else {
       _controller = YoutubePlayerController(
@@ -60,7 +60,7 @@ class _ThunderYoutubePlayerState extends State<ThunderYoutubePlayer> with Single
       );
       _controller
         ..loadVideoById(videoId: ypf.YoutubePlayer.convertUrlToId(widget.videoUrl)!)
-        ..setPlaybackRate(double.parse(state.videoDefaultPlaybackSpeed.label.replaceAll('x', '')));
+        ..setPlaybackRate(state.videoDefaultPlaybackSpeed.value);
     }
 
     setState(() => muted = state.videoAutoMute);