Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comment show up on the top of the thread #498

Closed
KarkanAlzwayed opened this issue Jul 30, 2023 · 2 comments
Closed

Make comment show up on the top of the thread #498

KarkanAlzwayed opened this issue Jul 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version

Comments

@KarkanAlzwayed
Copy link

Commenting on a post throws my comment to the very bottom of the post. Getting to it gets really cumbersome when the thread is long, in case I want to proofread or edit it. When I comment, it should be at the very top in my opinion.

@KarkanAlzwayed KarkanAlzwayed added the enhancement New feature or request label Jul 30, 2023
@ajsosa
Copy link
Collaborator

ajsosa commented Sep 7, 2023

So we currently don't have the code in place for inserting a comment into place. What is actually happening is after the new comment is created, the page is refreshed according to the comment sort setting you have selected. This also why you end up back at the top of the post.

I'm working on building out the comment insertion functionality. I don't think showing your comment at the top of the thread is the right way to go about this. The way I'm hoping to get this to work is to keep your place in the comment section so you can immediately see your comment in the correct context when replying. For top level comments I want to insert it into the correct place based on your selected sort setting and auto-scroll to it. That's my hope anyway.

@ajsosa
Copy link
Collaborator

ajsosa commented Sep 7, 2023

Actually, after speaking with the team, we'll place top level comments at the top.

@ajsosa ajsosa self-assigned this Sep 7, 2023
@ajsosa ajsosa added the in-progress Indicates that an issue is currently being worked on label Sep 7, 2023
hjiangsu added a commit that referenced this issue Sep 12, 2023
#498 Insert new comments without refrshing
@ajsosa ajsosa added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants