-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spoiler titles #1033
Improve spoiler titles #1033
Conversation
Ahh yeah, I initially had InkWells for the spoiler markdown as you indicated in the example, but I bumped into the same issue! I do want the text the be aligned with the rest of the text otherwise I feel like it looks out of place. I didn't have a good solution at that time so I left the InkWell out 😅 |
It looks like this is a bit of a catch-22. The |
Quick update! I tried everything I could, but I could not prevent the clipping that I was seeing from the horizontal transformation within the sidebars. I even tried setting My last solution is support conditional transformation. It's a bit clunky, but now things look good both in regular views and in the sidebars. The only exception is that in the sidebars, there is no left padding between the spoiler title and the edge of the Here is the latest demo, let me know what you think.. qemu-system-x86_64_xl0oLBGqBh.mp4 |
I think this works! Thanks for doing this, and figuring this out! |
Pull Request Description
Important
The following description has changed slightly. Please read all the comments in the thread.
This PR has a couple small tweaks for spoilers.
Material
as the root widget ofCommonMarkdownBody
. This should ensure thatInkWell
s always work (which they previously didn't in places like community sidebar).InkWell
was cut off, so only the right side was rounded. However, I also didn't like the text being misaligned, so I removed the left padding. This means the text now bumps up against theInkWell
, but I think it looks better than having square corners.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
After
spoiler_title_after.mp4
Checklist
semanticLabel
s where applicable for accessibility?