Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create cross-posts from app bar button #1034

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 10, 2024

Pull Request Description

This PR adds the ability to create a new cross-post from the app bar menu. This is needed because, although the CrossPosts widget has a button for that, it is only displayed if the post is already a cross-post. This new menu item will allow the function to be accessed regardless of the state of the current post.

I decided to add this to an overflow menu rather than directly on the app bar because I figured we'd have more buttons soon!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_qILo6mFAWO.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

Thanks for getting to this! I do have one point for discussion, mainly on how cross-posts work on Lemmy.

It looks like we're only handling the case where cross-posts can be created for links/images. I believe we can also create cross-posts for text posts. In this case, the post body gets copied over and is placed into a block quote markdown. We can do something similar in this case, or just copy that over without any changes.

This is an example of a text cross-post: https://lemmy.world/post/10508184

@micahmo
Copy link
Member Author

micahmo commented Jan 10, 2024

Sure, we can support creating cross-posts from text posts! My only concern is that it's not a "real" cross-post in the sense that Lemmy has no knowledge of the original post nor any linkage between them.

I like the example you gave. Do you think we should follow it exactly? Like this?


Cross-posted from: <original post link>

<original text>

@hjiangsu
Copy link
Member

My only concern is that it's not a "real" cross-post in the sense that Lemmy has no knowledge of the original post nor any linkage between them.

I agree, but I still think we should try to match parity with what Lemmy UI does!

Do you think we should follow it exactly? Like this?

I think thats fine!

@micahmo
Copy link
Member Author

micahmo commented Jan 10, 2024

All set!

qemu-system-x86_64_VlHSGa2P3e.mp4

@hjiangsu
Copy link
Member

Looks good now. Thanks for doing that!

@hjiangsu hjiangsu merged commit 7045082 into thunder-app:develop Jan 11, 2024
1 check passed
@micahmo micahmo deleted the feature/create-new-cross-post-button branch January 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants