Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share communities #1040

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Share communities #1040

merged 1 commit into from
Jan 15, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 11, 2024

Pull Request Description

This PR adds the ability to share communities.

Issue Being Fixed

Issue Number: #1037

Screenshots / Recordings

qemu-system-x86_64_0SrkNaPSpt.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

ggichure
ggichure approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hjiangsu hjiangsu merged commit de9d335 into thunder-app:develop Jan 15, 2024
1 check passed
@micahmo micahmo deleted the feature/share-communities branch January 15, 2024 21:53
@ggichure ggichure mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

@ggichure ggichure ggichure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micahmo @hjiangsu @ggichure