Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few things changed by type badge refactor #1067

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 19, 2024

Pull Request Description

This PR fixes a few things changed by #1066.

  1. The profile page should not dim posts (because the assumption is that everything there is already read).
    • Here (and other places) the indicateRead parameter was removed. But we can't get this just from the ThunderState since some places override it. When adding this value back, I did make it optional so that we should have to pass it around less.
  2. I reverted the change to the image icon. I'm finding that image_rounded is very heavy, especially in light mode where it's essentially dark on dark. image_outlined looks better to my eye! Of course if you disagree, I can put it back!
Before After
image image

Sorry for not catching these!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for catching these (I didn't realize I changed the image_rounded)

@hjiangsu hjiangsu merged commit 4eb5b34 into thunder-app:develop Jan 19, 2024
1 check passed
@micahmo micahmo deleted the fix/refactor-changes branch January 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants