-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable Post Card Metadata #1077
Conversation
Wow, this is so cool! I haven't looked at the code yet, but I love the demo! I haven't seen anything like this in any other app! |
I got this idea from Mlem - I saw it in their app and thought it was a really cool idea! I'll try to post a video of how they implement this. Theirs is a bit more refined in that you can adjust the metadata around once you add it in. Thats the final effect I'd like to achieve, but it seems a bit tricky! RPReplay_Final1705947369.mp4 |
…/customizable-post-card-metadata
Some more recordings on the overall UI/UX! There's a slight issue with the community icon on the card preview which I'll fix! Let me know your thoughts, I'm still very much open to changing the overall look based on feedback trim.A3A16BDF-7111-43BB-A133-6810FD8B6545.MOVtrim.468DBC78-F983-4999-923E-229E27E500BB.MOV |
It looks awesome! The only feedback I have is that, seeing the widgets in their own little chip makes me wonder if that would actually be an improvement for the final UI! Haha! I know that wasn't your intention, but I kind of like the look. It helps to separate the data so it doesn't all run together. Maybe it could be an option. But for your goal for this PR, I love it. |
I was messing around with the UI to see how it would be with the chips, but I feel like there's so little horizontal real estate that it makes it more difficult to accomplish well 😆. We can add this in as an option if interested though in a different PR! P.S. I really like having all the information be displayed in one line, rather than it wrapping around since it feels cleaner! |
…/customizable-post-card-metadata
I believe this should be good for review now! Let me know how everything feels and if you'd like me to make any changes to this! @micahmo @ggichure Note: There are some changes to the minimum iOS deployment target - I believe this was automatically changed when I updated flutter on my end (to version 3.16.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
Sorry for completely missing the discussion here, but this is incredible! Nice work! |
Pull Request Description
This draft PR adds the ability to customize the post card metadata. Currently, it handles the compact mode, but work is being done to implement it for the card view.
There's a few new things implemented here:
PostCardMetadata
widget was completely refactored to handle this new use-case. The individual post metadata have been re-implemented in separate widgets, andPostCardMetadata
composes it's widget from those individual metadata widgets. This allows us to add even more types of widgets in the future if we decide to.This is still in draft as there's some cleanup that needs to be addressed (localization strings, general code cleanup) and the card view settings have yet to be implemented in.
I would like to get some feedback on this implementation if possible (e.g., placement of settings, visual UI/UX, general thoughts)! @micahmo @machinaeZER0 @ggichure
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Here is a preview of how the settings drag and drop interface works.
705f2203-868a-40df-90df-7bdda6720525.mp4
Checklist
semanticLabel
s where applicable for accessibility?