Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where app language bottom sheet would fill full height #1089

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR addresses a small fix where the App Language bottom sheet would take up the full height of the screen. When this happens, it's not possible to drag the bottom sheet to be dismissed. The only way around this is to select on a language option to dismiss the bottom sheet.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before After
simulator_screenshot_F9E023F7-4FA1-4EC3-BC55-94436C2ECD49 simulator_screenshot_42DEF81E-69A2-4598-B8DC-0C1D514AD1F2

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 90fbcd2 into develop Jan 28, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/app-language-bottom-sheet branch January 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants