Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community search #1108

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 1, 2024

Pull Request Description

This PR adds the ability to initiate a search from a community. We already have the ability to search communities from the main search page, but I often find that I'm already in a community and want to search just that community without losing my spot. Now there's a new menu item which will push a new search page on the stack.

The community-specific search page will have a few limitations.

  • Only search for posts/comments
  • No feed type filter
  • Search box hint and no results hit now references community name
    • Body hint is hidden
  • No community filter

I also refactored the PopupMenuItems

Review without whitespace

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_jM8TXf31bU.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this. LGTM (just merge conflicts to handle and it should be good 😊)!

@micahmo
Copy link
Member Author

micahmo commented Feb 12, 2024

Sorry for the delay in reviewing this. LGTM (just merge conflicts to handle and it should be good 😊)!

No problem! Should be all set now!

@hjiangsu hjiangsu merged commit ccd0707 into thunder-app:develop Feb 12, 2024
1 check passed
@micahmo micahmo deleted the feautre/community-search branch February 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants