Fix notifications page state issue #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is the culmination of a lot of effort to fix an issue that's been really bugging me lately. See #1109 for the full history.
Long story short, I was finally able to reproduce this issue consistently! None of my previous attempts to fix were related to the problem. In fact, the problem only occurred when using the Android back button, which is probably why I happened to see it on my physical device but not the emulator, where it's a bit clunky to use the gesture. It also turns out to be the exact same problem as #1149. I still can't explain why using the gesture causes the
SwipeablePageRouteto completely rebuild, but at least I know how to fix it now.This PR will supersede #1109, which can probably be closed now.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
notif-state-before.mp4
After
notif-state-after.mp4
Checklist
semanticLabels where applicable for accessibility?