Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user/community styles #1201

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 13, 2024

Pull Request Description

This PR adds more configuration options for user and community full name styles.

Background

In #973 we introduced the ability to choose the style of user and community full names (either a@b or a · b, and more recently ! and @ were added as prefixes). Then in #944, @ggichure added a cool new style for comment usernames where the username is more weighted than the instance name. However, that new format is only available in comments and is not configurable. Then in #1092, @ggichure added colorized usernames, but the same restrictions applied.

This PR aims to make the "style" of the full names configurable universally in the same way that the "format" is currently configurable.

Notes

  • The commentUseColorizedUsername setting has been eliminated in favor of the new username style settings. However, there is a link from the Appearance > Comments page to the new setting (see demo), and there is a migration.
  • To ease into this change, and since the special formatting and colorized usernames previously only applied to comments, I am only applying these new changes there as well. However (as should be obvious from the introduction), the goal is to replace all usages of user/community names with these new formatting options, including adding full names where they are not already available (e.g., #1198).

CC: @ggichure

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_OFhdyh5XLh.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for me to get to this PR - I think its really cool and it looks great!

One slight modification I would make (but I'll leave the final decision to you) is to rename "Weight" to "Bold" (e.g., "Bold user name", Bold instance name"). I think "bold" is easier to understand than "weight", but that's just my personal opinion 😅

Let me know what you think! Otherwise, LGTM

@micahmo
Copy link
Member Author

micahmo commented Mar 21, 2024

rename "Weight" to "Bold"

I agree, that's a more user-friendly term. I think I'll continue to use weight in code, since that corresponds to the text styling.

Should be good now!

image

@hjiangsu hjiangsu merged commit f494249 into thunder-app:develop Mar 21, 2024
1 check passed
@micahmo micahmo deleted the feature/user-community-styles branch March 21, 2024 15:16
@micahmo micahmo mentioned this pull request Mar 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants