-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in-app changelog #1208
Merged
hjiangsu
merged 7 commits into
thunder-app:develop
from
micahmo:feature/in-app-changelog
Mar 20, 2024
Merged
Add in-app changelog #1208
hjiangsu
merged 7 commits into
thunder-app:develop
from
micahmo:feature/in-app-changelog
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good! Just a couple of minor things:
- For the settings label, we can reword it to "Show Update Changelogs" (the subtitle can be left as is)
- For the bottom sheet title, we can rename it to display "{version} Release Notes" (e.g., v0.3.0-1 Release Notes). I think that's a bit more concise than what its set to right now!
- I'm not sure how I feel about having 3 buttons at the bottom. Ideally, I'd like to reduce it down to two ("Close" and "Disable Release Notes"). I did try to experiment with the changes to see if I could use something like a DraggableScrollableSheet so that we don't need to have the "Expand" option, but I wasn't able to get it to work just right. I think we can leave it as is for now (but maybe subject to change in the future)
Thanks for the changes! I think all of the changes were reasonable! |
Oops, I didn't push the title change. Let me make a new small PR for that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for an (optional) in-app message and changelog for when the app is updated.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Note
In this demo, I have the dialog appearing for every restart of the app so I can demonstrate the settings. In reality, it should only appear when the version has changed.
qemu-system-x86_64_MFeSZNfYs2.mp4
Checklist
semanticLabel
s where applicable for accessibility?