Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modlog link handling #1223

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 21, 2024

Pull Request Description

I've been seeing a lot of direct links to modlogs, so I thought it would be cool if we could parse those as deep links to Thunder! This PR adds support for handling modlog links, both within the app and externally.

It should support all of the potential parameters, except page, since I wasn't sure how to make that work with how we currently support paging in the modlog.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Video was too big for GitHub.

https://files.catbox.moe/a5wphw.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It should support all of the potential parameters, except page, since I wasn't sure how to make that work with how we currently support paging in the modlog.

Yeah, this would take some work to support so I think its okay for the time being!

@hjiangsu hjiangsu merged commit 2265482 into thunder-app:develop Mar 23, 2024
1 check passed
@micahmo micahmo deleted the feautre/handle-modlog-links branch March 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants