Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable feed card divider #1230

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Mar 23, 2024

Pull Request Description

This PR adds a new way to customize the divider between posts/comments in the feed page. You can customize both the height and the colour of the divider. As part of this, I also made some tweaks to make some parameters optional in ListPickerItem and ListOption

Issue Being Fixed

This is related to some feedback from a post in the Thunder community: https://lemmy.world/post/13333300

Issue Number: N/A

Screenshots / Recordings

95441758-1095-4baf-9748-104dd1eabce9.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like the new options for settings. We could probably use a similar technique to clean up and group other settings.

@hjiangsu hjiangsu merged commit 815d096 into develop Mar 23, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/customizable-divider branch March 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants