Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text wrapping #1232

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix text wrapping #1232

merged 1 commit into from
Mar 25, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 24, 2024

Pull Request Description

This PR fixes an issue where all titles of bottom picker items were limited to one line, but that breaks cases where we want it to wrap. Since that was done to accommodate user/community names in #1199, and since we're now putting those names in the subtitle, I've just reverted that change.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before After
image image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 16c5ba2 into thunder-app:develop Mar 25, 2024
1 check passed
@micahmo micahmo deleted the fix/wrapping-issue branch March 25, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants