Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show post author subtitle #1253

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 29, 2024

Pull Request Description

This is a super tiny PR which adds a description to the "Show Post Author" setting. While experimenting which the new name settings, I found it was valuable to enable "Show User Instance" even when "Show Post Author" is off, because the post author is always shown in community feeds. I figured adding a little description to this effect would help others realize the same thing.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 0b2cd79 into thunder-app:develop Mar 29, 2024
1 check passed
@micahmo micahmo deleted the feature/show-post-author-subtitle branch March 31, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants