Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login issue #1274

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix login issue #1274

merged 1 commit into from
Apr 4, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 4, 2024

Pull Request Description

This PR fixes an issue with switching to a new account after logging in, which is related to the recent db migration (#1266). It looks like the problem is that, in on<LoginAttempt> we still used the old accountId format (which was a Uuid) as the active_profile_id in the sharedPreferences. The fix is to grab the newly insert id from insertAccount and put that in active_profile_id.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

login-issue.mp4

After

login-issue-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

hjiangsu commented Apr 4, 2024

Ahh, I can't believe I missed this during testing 🤦. You're completely right! I made changes to the primary key id to be an auto-increment integer rather than a UUID string.

I think this might also potentially affect adding new favorites then since that was previously using UUID strings for the primary key as well. Edit: it looks like you got to that as well! Thanks for the fix

@hjiangsu hjiangsu merged commit 0a184a0 into thunder-app:develop Apr 4, 2024
1 check passed
@micahmo micahmo deleted the fix/login-issue branch April 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants